transactional recovery in initPid #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apurvam
approved these changes
Apr 14, 2017
| }), Seq(metadata.pid)) | ||
| } else { | ||
| // reset the metadata and respond with new epoch | ||
| // TODO: should this append to the transaction log?, i.e., it doesn't above in the None case |
There was a problem hiding this comment.
Not sure I follow this comment. If you are bumping the epoch, the new epoch must go to the transaction log. Otherwise the epoch will 'roll backward` if the coordinator moves. Or does this comment mean something else?
There was a problem hiding this comment.
See here for the note on how to handle the initPidRequest. the case above when there is no previous record also needs to be updated. It is a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.