MINOR: fix test after upstream change #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream fix: apache/kafka#14426
|
|
mjsax
commented
Mar 6, 2024
| @@ -134,6 +134,7 @@ public void shouldJoinTwoStreams() { | |||
| impressionInput.pipeKeyValueList(inputAdImpressions); | |||
| clickInput.pipeKeyValueList(inputAdClicks); | |||
| // Flush result | |||
| topologyTestDriver.advanceWallClockTime(Duration.ofSeconds(1L)); | |||
There was a problem hiding this comment.
It's a little unclear why this was not necessary to begin with... w/o advancing wall-clock time, we might not flush due to wall-clock time base "flush throttling".
This was also notices on the upstream PR (apache/kafka#14426 (comment)) so it actually seems the PR did change this behavior a little bit (unclear what the exact root cause is -- nobody did investigate further, and seems it's not worth to spend time on?)
wcarlson5
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream fix: apache/kafka#14426