fix(Schema Registry): append '/' to RestService.BaseAddress and remove '/' from subject requests
#996
Conversation
…ove '/' from subject requests
|
It looks like @jonathansant hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
|
[clabot:check] |
|
@confluentinc It looks like @jonathansant just signed our Contributor License Agreement. 👍 Always at your service, clabot |
| private static string SanitizeUri(string uri) | ||
| { | ||
| var sanitized = uri.StartsWith("http", StringComparison.Ordinal) ? uri : $"http://{uri}"; | ||
| return $"{Regex.Replace(sanitized, "(/$)+", string.Empty)}/"; |
There was a problem hiding this comment.
can you change this to not use System.Text.RegularExpressions? i think this might result in an assembly being loaded that otherwise wouldn't be, and the logic's simple enough that using a regex doesn't add much.
|
thanks! I think a number of people have hit this issue. |
fixes: #993