Cw4 stake to control valset

[maurolacy]

Closes #6.

Based on #5 (cw4-group) tests. Tests are a little redundant and verbose in the name of clarity.

The pair cw4-stake + valset seems to be working well.

Will now add some unit tests to solve the TODOs from #5. Not sure what else needs to be tested.

[ethanfrey]

Stake test looks good.
I would definitely prefer literal values for the expected results, but the actual setup and expectations is correct.

[ethanfrey]

Will now add some unit tests to solve the TODOs from #5. Not sure what else needs to be tested.

I assume this is still pending? And same comment with using more literals for the expected results (and smaller groups)

[maurolacy]

Will now add some unit tests to solve the TODOs from #5. Not sure what else needs to be tested.

I assume this is still pending?

It is. Working on it.

[ethanfrey]

Nice improvement.
The same can be done in some of the other tests in contract.rs when you work on those.

[maurolacy]

I was trying to do the end_block_run tests, and my idea was to use sudo to send the TgradeSudoMsg::EndWithValidatorUpdate message to call end_block, but for some reason, that is failing with:

`Result::unwrap()` on an `Err` value: "Error parsing into type alloc::string::String: Invalid type"

So, it seems to me that multi-test sudo is broken. Or, I'm using it incorrectly.

In any case, I think this can be reviewed and merged as-is. And I'll open a new issue to debug / fix multi-test sudo.

[maurolacy]

Oh, I solved it. It's just that I need a ContractWrapper created with new_with_sudo.

It would be nice to improve on the error message, though. It took me a couple of hours (including patching crates and so on) to find and realize this.

Update: See CosmWasm/cw-plus#278.

[ethanfrey]

Looks good. Let's merge it.

We can add more tests later when we optimize the cw4 calls, but this is good sanity checks

[ethanfrey]

Thanks for covering this

[ethanfrey]

perfect