Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump guest-components + ITA kustomization #497

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Sep 11, 2024

No description provided.

@mythi mythi requested a review from a team as a code owner September 11, 2024 10:07
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mythi!

@fidencio fidencio added the test_e2e Authorize TEE e2e test run label Sep 11, 2024
Comment on lines +5 to +7
images:
- name: ghcr.io/confidential-containers/key-broker-service:built-in-as-v0.9.0
newTag: ita-as-v0.9.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should pay attention to not forget to bump those during the release process.

cc @fitzthum, who's been maintaining the release guide (AFAIR).

Copy link
Member

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mythi.

lgtm

@Xynnn007
Copy link
Member

Thanks. Do we need to firstly bump gc and then change the rev of trustee to use that one?

@fidencio
Copy link
Member

Thanks. Do we need to firstly bump gc and then change the rev of trustee to use that one?

We're using the guest components hash of the latest commit, which includes the changes that we need, so I think we're good to go here @Xynnn007.

My next step will do bump everything on the Kata Containers side as soon as this one is merged.

@fidencio fidencio merged commit 6f767fa into confidential-containers:main Sep 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test_e2e Authorize TEE e2e test run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants