CLI: specify ATTESTER to build kbs-client #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
- Add ATTESTER in Makefile to specify seperate attester for kbs-client Signed-off-by: Lei Li <[email protected]> Signed-off-by: Lei Li <[email protected]>
genjuro214
changed the title
genjuro214
changed the title
Xynnn007
approved these changes
Jun 26, 2024
fitzthum
approved these changes
Jun 26, 2024
| @@ -20,6 +21,14 @@ else | |||
| AS_FEATURE = $(AS_TYPE) | |||
| endif | |||
|
|
|||
| ifndef CLI_FEATURES | |||
| ifdef ATTESTER | |||
| CLI_FEATURES = "sample_only,$(ATTESTER)" | |||
There was a problem hiding this comment.
It's a bit misleading to use both sample_only and another attester, but I guess we can live with that. I think we depend on this sample_only feature externally so we probably don't want to rename that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't build kbs-client on s390x host with default feature including all attesters.
I tried to add a new variable ATTESTER in Makefile, so that we can specify separate attester when building kbs-client
make cliwill build kbs-client with all attestersCLI_FEATURES=sample_only make cliATTESTER=se-attester make cli