CI: set expected tee in policy within the kbs e2e test #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkulke
force-pushed
the
mkulke/set-tee-in-e2e-test-policy
branch
from
76a225c to
6efc2ec
Compare
fitzthum
approved these changes
May 29, 2024
The e2e tests used to remove the tee != sample restriction from the policy prior to testing. Since we want to avoid using the sample attester accidentally, we can set the expected TEE in the policy. Signed-off-by: Magnus Kulke <[email protected]>
mkulke
force-pushed
the
mkulke/set-tee-in-e2e-test-policy
branch
from
6efc2ec to
a6ac8b5
Compare
fidencio
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e tests used to remove the tee != sample restriction from the policy prior to testing. Since we want to avoid using the sample attester accidentally, we can set the expected TEE in the policy.
The TEE e2e tests would fail here, because the interface of the workflow has been changed (introduced mandatory
teeinput) and it will be executed with the workflow from the main branch.I ran the workflow is a discrete branch to test here (using
tee: aztdxvtpm)