k8s-config: Add support for NodePort service type #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test this PR run the following set of commands: cd kbs/config/kubernetes
touch overlays/key.bin
kustomize build nodeport | grep -B 12 NodePort |
mythi
reviewed
Apr 18, 2024
kbs/config/kubernetes/README.md
Outdated
| @@ -44,6 +44,24 @@ kustomize edit add resource ingress.yaml | |||
| popd | |||
| ``` | |||
|
|
|||
| ## Optional: Expose KBS using Nodeport | |||
|
|
|||
| If you would like to expose KBS service using Nodeport then add the following snippet to the `overlays/kustomization.yaml` file in the `patches:` section: | |||
There was a problem hiding this comment.
My preference would be to have a dedicated kustomization for this, e.g, overlays/nodeport so that manual editing can be avoided.
Right now the KBS service is only exposed as the ClusterIP service type. And to be able to really use the KBS service you need to expose it using an Ingress, but this is not always feasible. So this commit adds a way for the KBS service to be exposed as a NodePort service type. Signed-off-by: Suraj Deshmukh <[email protected]>
surajssd
force-pushed
the
k8s-config-support-nodeport
branch
from
10723cb to
e6132f5
Compare
fitzthum
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the KBS service is only exposed as the
ClusterIP service type. And to be able to really
use the KBS service you need to expose it using an Ingress, but this is not always feasible. So this
commit adds a way for the KBS service to be
exposed as a NodePort service type.