Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Verifier CI coverage problem #299

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

Xynnn007
Copy link
Member

  1. Enables the CI test covering verifier crate
  2. Fix the unit tests inside Verifier crate, including
  • CCA: Change the test json path
  • SGX: new version of SGX verifier will also return abstract claim
    Report_data and init_data
  • TDX: new version of TDX verifier will also return abstract claim
    Report_data and init_data. Also, RTMRs will be returned.

Thanks to @mkulke for the reporting.

Fixes #298

Fix the unit tests inside Verifier crate, including
- CCA: Change the test json path
- SGX: new version of SGX verifier will also return abstract claim
`Report_data` and `init_data`
- TDX: new version of TDX verifier will also return abstract claim
`Report_data` and `init_data`. Also, RTMRs will be returned.

Fixes confidential-containers#298

Signed-off-by: Xynnn007 <[email protected]>
@Xynnn007 Xynnn007 requested a review from sameo as a code owner January 22, 2024 09:34
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fitzthum fitzthum merged commit 619a07c into confidential-containers:main Jan 22, 2024
12 checks passed
@Xynnn007 Xynnn007 deleted the fix-verifier-ci branch January 23, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: are we skipping unit tests in workflows?
2 participants