api_server: add SGX support to Amber AS #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikko Ylinen <[email protected]>
|
the SGX part tested with Amber, @Lu-Biao to help check TDX |
|
It works well with TDX. @mythi |
Xynnn007
approved these changes
Oct 10, 2023
| } | ||
| // get quote | ||
| let attestation = serde_json::from_str::<Attestation>(attestation) | ||
| .map_err(|e| anyhow!("Deserialize Attestation failed: {:?}", e))?; | ||
| let tdx_evidence = serde_json::from_str::<TdxEvidence>(&attestation.tee_evidence) | ||
| .map_err(|e| anyhow!("Deserialize TDX Evidence failed: {:?}", e))?; | ||
| let evidence = serde_json::from_str::<AmberTeeEvidence>(&attestation.tee_evidence) |
There was a problem hiding this comment.
We'd better raise an info or warn here to tell the user that eventlog is ignored.
There was a problem hiding this comment.
With amber, event_log needs to be added as a separate field in the appraisal request but it's currently not done so there's no change in functionality with this PR.
can we get it for the release? |
jialez0
approved these changes
Oct 26, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.