Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: update key-broker-service Dockerfile #152

Merged
merged 1 commit into from
Sep 4, 2023
Merged

docker: update key-broker-service Dockerfile #152

merged 1 commit into from
Sep 4, 2023

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Sep 1, 2023

Improvements and fixes:

  • openssl-sys fails to build without certain .pm files so the intermediate fix is to install perl.
  • reduce build steps and move "COPY" later in the build to allow caches to be used more efficiently (previously, a single modification to the repo files forced 1G of apt-get to be re-installed).
  • move away from deprecated apt-key.

@mythi
docker: update key-broker-service Dockerfile
aba16a3 
Improvements and fixes:

* openssl-sys fails to build without certain .pm files so
  the intermediate fix is to install perl.
* reduce build steps and move "COPY" later in the build to
  allow caches to be used more efficiently (previously, a single
  modification to the repo files forced 1G of apt-get to be re-installed).
* move away from deprecated apt-key.

Signed-off-by: Mikko Ylinen <[email protected]>
mythi
mythi commented Sep 1, 2023
View reviewed changes
docker/Dockerfile
RUN apt-get update && apt-get install -y apt-utils
RUN apt-get install -y \
RUN apt-get update && \
apt-get install -y \
clang \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: why is clang needed here? it makes the final image pretty big

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this operation, 978 MB of additional disk space will be used.

@mythi mythi mentioned this pull request Sep 1, 2023
Closed
fitzthum
fitzthum approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialez0 jialez0 merged commit 811b4fe into confidential-containers:main Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzthum fitzthum fitzthum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mythi @fitzthum @jialez0