Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-compose dependencies #140

Merged

Conversation

johananl
Copy link
Contributor

Right now the services are racing when running docker-compose up. Add depends_on clauses to the services to fix the race. This also allows running e.g. docker-compose up kbs which would start just KBS and its dependencies.

cc: @Xynnn007

Right now the services are racing when running `docker-compose up`. Add
depends_on clauses to the services to fix the race. This also allows
running e.g. `docker-compose up kbs` which would start just KBS and its
dependencies.

Signed-off-by: Johanan Liebermann <[email protected]>
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@fitzthum fitzthum merged commit 8ca7c4d into confidential-containers:main Jul 28, 2023
@johananl johananl deleted the docker-compose-dependencies branch July 28, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants