tools/client: move to CoCo AA, use single threaded runtime #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing because of #102 |
Xynnn007
reviewed
Jun 1, 2023
| @@ -13,8 +13,8 @@ base64.workspace = true | |||
| clap = { version = "4.0.29", features = ["derive"] } | |||
| env_logger.workspace = true | |||
| jwt-simple = "0.11.4" | |||
| kbs_protocol = { git = "https://github.com/jialez0/attestation-agent", branch = "token" } | |||
| kbs_protocol = { git = "https://github.com/confidential-containers/attestation-agent", rev = "aa1d3c5" } | |||
There was a problem hiding this comment.
This dependency relationship brings a potential problem:
If we want the code dependencies in each release to be self-consistent, here the rev of attestation-agent should be a release tag.
However there is a dilemma:
- release of
attestation-agentdepends onKBS: CI of guest stack should use a KBS/AS image. - release of
KBSdepends onattestation-agent: Here
There might be two different solutions to resolve
- move this tool to attestation-agent repo from here
- we first cut releases for guest stack using a self-built image in CI, after that update the
revhere and cut release for AS/KBS and finally replace the image in CI. Also we can think about @surajssd 's idea as Alpha release for v0.6.0 #96 (comment)
There was a problem hiding this comment.
While playing with the tool, I also thought about option 1 which would probably be the simplest "fix". I guess the caveat to that is that then there's no "sample client" in this repo.
|
@mythi Please rebase with the latest code. Ideally it could help pass the CI. |
Signed-off-by: Mikko Ylinen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.