CDH/KMS: remove ehsm from defaut features #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might be good to add this to the docs too? |
eHSM crate is no longer maintained and archived. Also, it requires openssl to be built thus cannot be built with musl. This patch removes it from default features of `kms` crate. If one wants to build CDH with eHSM support, `KMS_PROVIDER=ehsm` can be used when executing Makefile of CDH. Signed-off-by: Xynnn007 <[email protected]>
Xynnn007
force-pushed
the
fix-feature-ehsm
branch
from
679e363 to
a16eea5
Compare
mkulke
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eHSM crate is no longer maintained and archived. Also, it requires openssl to be built thus cannot be built with musl.
This patch removes it from default features of
kmscrate. If one wants to build CDH with eHSM support,KMS_PROVIDER=ehsmcan be used when executing Makefile of CDH.