Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdh:storage: Refactor luksFormat command to use --batch-mode #679

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

ChengyuZhu6
Copy link
Member

Use --batch-mode in luksFormat command.
This change improves the script by eliminating the need for echoing "YES", making it more streamlined and efficient.

Use --batch-mode in luksFormat command.
This change improves the script by eliminating the need for echoing "YES", making it more streamlined and efficient.

Signed-off-by: ChengyuZhu6 <[email protected]>
@ChengyuZhu6 ChengyuZhu6 marked this pull request as ready for review August 16, 2024 08:39
@ChengyuZhu6 ChengyuZhu6 requested a review from sameo as a code owner August 16, 2024 08:39
@ChengyuZhu6 ChengyuZhu6 changed the title storage: Refactor luksFormat command to use --batch-mode cdh:storage: Refactor luksFormat command to use --batch-mode Aug 16, 2024
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xynnn007 Xynnn007 merged commit 46e535a into confidential-containers:main Aug 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants