image-rs: update cosign signature verification unit test #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit deletes a duplicated unit case for cosign signature scheme. Also, the original cosign signed test image is based on busybox, thus a successfully pulling for that image (busybox) via nydus-snapshotter would cause another pulling with policy preventing the image successful. This is because of some logic inside nydus-snapshotter. To handle this, we update the signed image to be a different one from busybox. Separately we will fix this on the snapshotter side. Signed-off-by: Xynnn007 <[email protected]>
Xynnn007
force-pushed
the
fix-cosign-image-test-image
branch
from
0caa821 to
127c00f
Compare
Xynnn007
requested review from
sameo,
jiangliu,
arronwy,
lumjjb and
jialez0
as code owners
arronwy
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deletes a duplicated unit case for cosign signature scheme.
Also, the original cosign signed test image is based on busybox, thus a successfully pulling for that image (busybox) via nydus-snapshotter would cause another pulling with policy preventing the image successful. This is because of some logic inside nydus-snapshotter.
To handle this, we update the signed image to be a different one from busybox. Separately we will fix this on the snapshotter side.
cc @stevenhorsman