AA: fix launch configuration #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkulke
approved these changes
Jun 24, 2024
| @@ -73,13 +73,15 @@ pub struct AttestationAgent { | |||
| } | |||
|
|
|||
| impl Default for AttestationAgent { | |||
| /// This function would panic if a malwared `aa_kbc_param` is given | |||
There was a problem hiding this comment.
Suggested change
| /// This function would panic if a malwared `aa_kbc_param` is given | |
| /// This function would panic if a malformed `aa_kbc_param` is given |
Before this commit, if no configuration and proper aa_kbc_param given to AA, the launch of AA will panic. This commit will use a default value for aa_kbc_param for AA/CDH. If no env or kernel cmdline, default value offline_fs_kbc and null will be used. If a aa_kbc_param is specified, it will be parsed as kbc:url. If the aa_kbc_param is malwared, the launch process will still fail. Signed-off-by: Xynnn007 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, if no configuration and proper aa_kbc_param given to AA, the launch of AA will panic.
This commit will use a default value for aa_kbc_param for AA/CDH. If no env or kernel cmdline, default value offline_fs_kbc and null will be used. If a aa_kbc_param is specified, it will be parsed as kbc:url. If the aa_kbc_param is malwared, the launch process will still fail.
cc @mkulke