Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibmse: add se attester to all-attesters #590

Merged
merged 3 commits into from
Jun 18, 2024
Merged

ibmse: add se attester to all-attesters #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb21b68
ibmse: add se attester to all-attesters
Jun 17, 2024
bc33980
ibmse: add an extra ? in se attester
Jun 18, 2024
3db84df
ibmse: remove s390x only comments in se attester
Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions attestation-agent/attestation-agent/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ kbs = ["kbs_protocol/background_check", "token"]
# CoCoAS Attestation Token
coco_as = ["reqwest", "token"]

all-attesters = ["tdx-attester", "sgx-attester", "az-snp-vtpm-attester", "az-tdx-vtpm-attester", "snp-attester"]
all-attesters = ["tdx-attester", "sgx-attester", "az-snp-vtpm-attester", "az-tdx-vtpm-attester", "snp-attester", "se-attester"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why the CI passes to build the binary as attester/se-attester seems to be built only on s390x? https://github.com/confidential-containers/guest-components/blob/main/attestation-agent/attester/Cargo.toml#L57-L58

https://github.com/confidential-containers/guest-components/actions/runs/9546379968/job/26309121829?pr=590#step:9:241

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

se-attester can also be built and run on x86 machine but can only been run on a s390x machine correctly. @Xynnn007

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can actually be run on x86 correctly because https://github.com/confidential-containers/guest-components/blob/main/attestation-agent/attester/src/se/mod.rs#L19 returns false on x86 instance.

tdx-attester = ["kbs_protocol?/tdx-attester", "attester/tdx-attester"]
sgx-attester = ["kbs_protocol?/sgx-attester", "attester/sgx-attester"]
az-snp-vtpm-attester = ["kbs_protocol?/az-snp-vtpm-attester", "attester/az-snp-vtpm-attester"]
az-tdx-vtpm-attester = ["kbs_protocol?/az-tdx-vtpm-attester", "attester/az-tdx-vtpm-attester"]
snp-attester = ["kbs_protocol?/snp-attester", "attester/snp-attester"]
se-attester = ["kbs_protocol/se-attester", "attester/se-attester"]
se-attester = ["kbs_protocol?/se-attester", "attester/se-attester"]

# Either `rust-crypto` or `openssl` should be enabled to work as underlying crypto module
rust-crypto = ["kbs_protocol?/rust-crypto"]
Expand Down
1 change: 0 additions & 1 deletion attestation-agent/attester/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ all-attesters = [
"snp-attester",
"csv-attester",
"cca-attester",
# se-attester feature can work only on s390x target arch.
"se-attester",
]

Expand Down
Loading