AA: add UpdateConfiguration API #549
Conversation
Xynnn007
force-pushed
the
aa-updateconf
branch
3 times, most recently
from
daa6ddb to
18ec35f
Compare
As discussed, this API is a workaround API for CoCo to apply initdata proposal. Once we agree on a better way (like systemd scheme), we can deprecate the API. Signed-off-by: Xynnn007 <[email protected]>
| tmpfile | ||
| .path() | ||
| .as_os_str() | ||
| .to_str() |
There was a problem hiding this comment.
If this function takes a str, can we just use that directly in try_from rather than writing it to a tmp file?
There was a problem hiding this comment.
The str here means the path. This is actually misleading.
There was a problem hiding this comment.
oh right. I didn't read this closely enough.
I'm not really a fan of the tmpfile thing but I guess we can live with it temporarily. Another approach would be to have the kata agent write the file, like it will with other configs and just take the path here.
What is the purpose of the underscore here?
There was a problem hiding this comment.
config is actually used only in the features coco-as and kbs. Without a underscore the lint will cry when we enable neither of them.
As discussed, this API is a workaround API for CoCo to apply initdata proposal. Once we agree on a better way (like systemd scheme), we can deprecate the API.
See kata-containers/kata-containers#9468
cc @fitzthum