image-rs: get rid of checking decrypt_config parameter
#523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xynnn007
requested review from
sameo,
jiangliu,
arronwy,
lumjjb and
jialez0
as code owners
Xynnn007
force-pushed
the
fix-pull-encrypt-image
branch
2 times, most recently
from
9acfabd to
5651b7d
Compare
The high level API of image-rs is `pull_image()`. There is one parameter named `decrypt_config` passed to the api, and the parameter is to specify the orignal kbc parameter, e.g. provider:attestation-agent:offline_fs_kbc:null However, different parts of the parameter is now specified - `attestation-agent`: the key to look up keyprovider is embedded inside the encrypted image layer annotation. - `offline_fs_kbc:null`: so-called AA_KBC_PARAMS, is defined in CDH if Kata-CC is used, so in this case, we do not to ensure the parameter is given as it will not be used. This is why we get rid of this parameter checking in this commit. In enclave-cc scenarios, the `decrypt_config` is still used, and we will check the parameter in concrete `ocicrypt-rs`'s `native` key provider plugin. Signed-off-by: Xynnn007 <[email protected]>
Xynnn007
force-pushed
the
fix-pull-encrypt-image
branch
from
5651b7d to
f3c4d5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The high level API of image-rs is
pull_image(). There is one parameter nameddecrypt_configpassed to the api, and the parameter is to specify the orignal kbc parameter, e.g.provider:attestation-agent:offline_fs_kbc:null
However, different parts of the parameter is now specified
attestation-agent: the key to look up keyprovider is embedded inside the encrypted image layer annotation.offline_fs_kbc:null: so-called AA_KBC_PARAMS, is defined in CDH if Kata-CC is used, so in this case, we do not to ensure the parameter is given as it will not be used. This is why we get rid of this parameter checking in this commit.In enclave-cc scenarios, the
decrypt_configis still used, and we will check the parameter in concreteocicrypt-rs'snativekey provider plugin.