-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image-rs: Add cargo build for multiarch #491
image-rs: Add cargo build for multiarch #491
Conversation
Hi Steve. #422 is fixed by @Xynnn007 . And it works on the guest pull PR https://github.com/kata-containers/kata-containers/actions/runs/8242824012/job/22542388463?pr=8484. |
b806a25
to
5c1ac60
Compare
Great - I've rebased, so we'll see if this is passes now 🤞 |
5c1ac60
to
274f355
Compare
We're getting ssl related errors on
I'm trying adding |
It doesn't seem to be working and it was previously, so maybe something in the stack has changed things? |
Oh. There is actually a hidden problem. openssl does not support cross-compilation in rust. The logic code in image-rs does not reference openssl, but it is used in the unit test, so the cargo test here cannot be built successfully. Let me fix this in another PR and you can rebase the code. hopefully it works. |
274f355
to
7fb616e
Compare
We're now failing with:
I guess this was silly of me to try and run tests against a different platform binaries, so I could switch this to just a |
Makes sense. Once we have a s390x test machine, we can do the test. :P |
We do have an s390x test-runner in the CoCo organisation, so that might be a possibility. \cc @BbolroC |
- Add build of image-rs on s390x and powerpc64le Signed-off-by: stevenhorsman <[email protected]>
7fb616e
to
4f457ce
Compare
Yeah, we can use the current s390x runner for this. |
All checks are passing now, so I've moved this out of draft. Thanks so much Ding for removing the blockers on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks @stevenhorsman
Note: At the moment this will probably fail with:
whilst we wait for #422 to get fixed, so we shouldn't merge it until after that is fixed