Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AA: Add coco_as feature to cc_kbc to default support CoCo-AS #459

Merged
merged 1 commit into from
Jan 26, 2024
Merged

AA: Add coco_as feature to cc_kbc to default support CoCo-AS #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion attestation-agent/lib/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ default = ["sample_kbc", "rust-crypto", "coco_as"]
kbs = ["kbs_protocol/background_check"]
coco_as = ["reqwest"]

cc_kbc = ["kbc/cc_kbc", "kbs_protocol/background_check", "kbs"]
cc_kbc = ["kbc/cc_kbc", "kbs_protocol/background_check", "kbs", "coco_as"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting that cc_kbc is an old name to specify the kbc. But now kbc implementations are moved to CDH, thus only attester/platform should be configured for AA.

In future, we might also need to delete all *-kbc features and instead only leave *-attester and different kinds of token features.

But currently, it is ok to me.

all-attesters = ["kbc/all-attesters", "kbs_protocol?/all-attesters", "attester/all-attesters"]
tdx-attester = ["kbc/tdx-attester", "kbs_protocol/tdx-attester", "attester/tdx-attester"]
sgx-attester = ["kbc/sgx-attester", "kbs_protocol/sgx-attester", "attester/sgx-attester"]
Expand Down
Loading