Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: support to build components for all platforms and amd #453

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

Xynnn007
Copy link
Member

@Xynnn007 Xynnn007 commented Jan 25, 2024

TEE_PLATFORM=all to support a easy mode for users to build all guest components with all features enabled (including the attester plugins, etc)

TEE_PLATFORM=amd supports to build components of sev & snp.

Also, fixed a bug in CDH when both kbs and sev features are enabled. We not will initialize sev when aa_kbc_param is set to sev.

This is to support a easy mode for users to build all guest components
with all features enabled (including the attester plugins, etc)

Also, fixed a bug in CDH when both kbs and sev features are enabled. We
not will initialize sev when `aa_kbc_param` is set to `sev`.

Signed-off-by: Xynnn007 <[email protected]>
@Xynnn007 Xynnn007 requested a review from sameo as a code owner January 25, 2024 02:16
This target aims to build components with both sev and snp support,
which is useful in building rootfs of sev & snp which both platform
share.

Signed-off-by: Xynnn007 <[email protected]>
@Xynnn007 Xynnn007 changed the title Makefile: support to build components for all platforms Makefile: support to build components for all platforms and amd Jan 25, 2024
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Xynnn007!

@Xynnn007 Xynnn007 merged commit b595eb6 into confidential-containers:main Jan 25, 2024
12 checks passed
@Xynnn007 Xynnn007 deleted the makefile-all branch January 25, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants