Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add platform Makefile to quickly build guest component binaries #407

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

Xynnn007
Copy link
Member

@Xynnn007 Xynnn007 commented Dec 12, 2023

Currently we are building AA/CDH/ASR with different and complex compiling parameters controls. To make it simpler for default cases, this commit adds a Makefile with the following assumption:

test: libc=musl, KBC=offline_fs_kbc
tdx: libc=gnu, KBC=cc_kbc_tdx
sev: libc=musl, KBC=online_sev_kbc

Fixes #373

Hi @stevenhorsman @Alex-Carter01 @fidencio @arronwy Please check if it is as expected.

Currently we are building AA/CDH/ASR with different and complex
compiling parameters controls. To make it simpler for default cases,
this commit adds a Makefile with the following assumption:

test: libc=musl, KBC=offline_fs_kbc
tdx: libc=gnu, KBC=cc_kbc_tdx
sev: lib=musl, KBC=online_sev_kbc

Fixes confidential-containers#373

Signed-off-by: Xynnn007 <[email protected]>
@Xynnn007 Xynnn007 requested a review from sameo as a code owner December 12, 2023 09:09
@Xynnn007 Xynnn007 changed the title Makefile: add overall Makefile Makefile: add platform Makefile to quickly build guest component binaries Dec 12, 2023
@Alex-Carter01
Copy link
Contributor

The SEV case makes sense

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

I think we can add SNP support just with KBC = cc_kbc_snp

@fitzthum fitzthum merged commit 4d00bac into confidential-containers:main Dec 14, 2023
3 checks passed
@Xynnn007 Xynnn007 deleted the makefile-arch branch December 15, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile: support build different artifacts due to given TEE_PLATFORM
3 participants