Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kbs_protocol: use rusttls when rust-crypto feature is enabled #307

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Aug 1, 2023

reqwest uses the platform's native TLS stack by default, also when rusttls is enabled.

Force reqwest Client to use rustls TLS stack when rust-crypto feature is enabled. This is what users most likely expect to get.

reqwest uses the platform's native TLS stack by default, also
when rusttls is enabled.

Force reqwest Client to use rustls TLS stack when rust-crypto
feature is enabled. This is what users most likely expect to
get.

Signed-off-by: Mikko Ylinen <[email protected]>
@mythi mythi requested a review from jialez0 as a code owner August 1, 2023 15:27
Copy link
Member

@jialez0 jialez0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jialez0
Copy link
Member

jialez0 commented Aug 2, 2023

cc @Xynnn007 . This should also be added to your PR #304 .

@mythi
Copy link
Contributor Author

mythi commented Aug 2, 2023

cc @Xynnn007 . This should also be added to your PR #304 .

There's no dependency though. I've tested with my use-case so I believe it can go alone as well.

@jialez0 jialez0 merged commit a86a7ea into confidential-containers:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants