Add unit test case for unencrypted images #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…key to offline-fs-kbc for encrypted test Signed-off-by: Chris Porter <[email protected]>
portersrc
requested review from
sameo,
jiangliu,
arronwy,
lumjjb,
jialez0 and
Xynnn007
as code owners
Xynnn007
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue 101
I added an unencrypted test case.
Also, I removed the previous encrypted test case, which was pulling from here:
docker.io/xynnn007/busybox:encrypted-uri-key
And I replaced it with an encrypted test case, which pulls from here:
ghcr.io/confidential-containers/test-container:encrypted
Reasoning: I assume we want to tie this to the CC project on GHCR while we're here and move it off of @Xynnn007's image.