Tidy up the warnings from integration tests #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e extraneous warnings Signed-off-by: Chris Porter <[email protected]>
portersrc
requested review from
sameo,
jiangliu,
arronwy,
lumjjb,
jialez0 and
Xynnn007
as code owners
Xynnn007
added a commit
to Xynnn007/guest-components
that referenced
this pull request
Jul 13, 2023
Related to confidential-containers#279 Signed-off-by: Xynnn007 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the "Files changed" in recent PRs, there are many extraneous warnings in image-rs/tests (e.g. "unused import"). The two main causes seem to be:
(1) the appropriate annotation for an integration test is not always applied to the respective import statement, variable, etc.
(2) not all integration tests use all of the common support from image-rs/tests/common/mod.rs
This PR tries to resolve the warnings. Annotations are added to solve (1). For (2), I've added
pub mod commonto the integration tests, which could lead to actual dead code that won't get caught by warnings. This seems to be a reasonable workaround, however, due to this issue.