image-rs: improve AA build and output #274
Conversation
Improving output when building and starting AA. Placing gRPC and ttRPC binaries in different directories, so both can be cached and it is clear what feature the binary supports. Signed-off-by: Paul Meyer <[email protected]>
katexochen
requested review from
sameo,
jiangliu,
arronwy,
lumjjb,
jialez0 and
Xynnn007
as code owners
| parameters+=("ttrpc=true") | ||
| dest_dir_suffix="ttrpc" | ||
| else | ||
| dest_dir_suffix="grpc" |
There was a problem hiding this comment.
Will we also need changes to the kata initrd building scripts and peer pods tooling to account for the new location?
There was a problem hiding this comment.
I'm not sure I understand that question. I think this build script is only ever called by the image-rs tests. Everything else should use the attestation-agents Makefile. The small modification to the attestation-agent Makefile should only change behavior in edge cases.
| .kill_on_drop(true) | ||
| .args(&[ | ||
| "--keyprovider_sock", | ||
| "unix:///run/confidential-containers/attestation-agent/keyprovider.sock", | ||
| "--getresource_sock", | ||
| "unix:///run/confidential-containers/attestation-agent/getresource.sock" | ||
| ]) | ||
| .spawn()?; | ||
| .spawn() | ||
| .expect("Failed to start ttrpc attestation-agent"); |
There was a problem hiding this comment.
Nothing against this more verbose error but note that currently the --help flag will tell you if the AA was built with grpc or ttrpc.
There was a problem hiding this comment.
That can be helpful for local development, but won't help for debugging CI runs.
Improving output when building and starting AA.
Placing gRPC and ttRPC binaries in different directories, so both can be cached and it is clear what feature the binary supports.
Test itself was already fixed in #271.