Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of ring dependency #134

Closed
Xynnn007 opened this issue Apr 6, 2023 · 1 comment · Fixed by #135
Closed

Get rid of ring dependency #134

Xynnn007 opened this issue Apr 6, 2023 · 1 comment · Fixed by #135
Assignees
@Xynnn007

Comments

@Xynnn007
Copy link
Member

Xynnn007 commented Apr 6, 2023

Background

For ring dependency cannot be built on s390x, s390x cannot support cosign for a few months. Latest sigstore-rs does not depends on ring anymore. Time to update.

What we want

Update sigstore-rs to rev 69e8f33.
@Xynnn007 Xynnn007 self-assigned this Apr 6, 2023
@Xynnn007
Copy link
Member Author

Xynnn007 commented Apr 6, 2023

We need to resolve #255 first.

@Xynnn007 Xynnn007 mentioned this issue Apr 7, 2023
Merged
@Xynnn007 Xynnn007 moved this to 🆕 New in CoCo Releases Apr 7, 2023
@Xynnn007 Xynnn007 removed this from CoCo Releases Apr 7, 2023
@Xynnn007 Xynnn007 mentioned this issue Apr 7, 2023
Closed
arronwy pushed a commit that referenced this issue Apr 24, 2023
@Xynnn007 @arronwy
Dep: bring in rustls and native-tls features
b3e939c 
`sigstore-rs` has features `native-tls` and `rustls-tls`. The
two features are leveraged to give two types of build:

`kata-cc-rustls-tls` and `enclave-cc-rustls-tls`: they depend on purely
rust implementation of crypto suites, including `ring` which can
not be built on `s390x`.

`kata-cc-native-tls` and `enclave-cc-native-tls`: they depend on `openssl`
for crypto suites. They can be built on `s390x`.

sync blocking is used because the current implementation of oci
client is not `Send` between threads.

Fixes: #134

Signed-off-by: Xynnn007 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xynnn007 Xynnn007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix remove ring
1 participant
@Xynnn007