Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests & CI framework #243

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Add tests & CI framework #243

merged 6 commits into from
Jan 9, 2025

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Jan 8, 2025

Description

Add test CI framework per comment: #238 (comment)

And uploads coverage reports

Closes #242

@kenodegard kenodegard requested a review from a team as a code owner January 8, 2025 03:00
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 8, 2025
@kenodegard kenodegard mentioned this pull request Jan 8, 2025
python-version: '3.11'

- name: Install Dependencies
run: pip install --quiet -r requirements.txt -r combine-durations/requirements.txt -r template-files/requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: pip install --quiet -r requirements.txt -r combine-durations/requirements.txt -r template-files/requirements.txt
run: pip install --quiet -r requirements.txt -r template-files/requirements.txt

I can't find combine-durations/requirements.txt in the PR, did you forget to add it or is the call here old?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks! I've had tomatoes on my eyes, as the German saying goes

python-version: '3.11'

- name: Install Dependencies
run: pip install --quiet -r requirements.txt -r combine-durations/requirements.txt -r template-files/requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks! I've had tomatoes on my eyes, as the German saying goes

@jezdez jezdez merged commit 3cf0d52 into main Jan 9, 2025
4 checks passed
@jezdez jezdez deleted the add-tests branch January 9, 2025 14:56
@kenodegard kenodegard mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add an action to run tests as part of pull requests (and some trivial "starter" tests)
3 participants