Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Python >= 3.8 #43

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Bump to Python >= 3.8 #43

merged 1 commit into from
Jul 10, 2023

Conversation

johnhany97
Copy link
Contributor

@johnhany97 johnhany97 commented Jul 10, 2023

With jaraco/zipp@4269d27, consumers still on python 3.7 may end up picking this up and failing at runtime.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@johnhany97 johnhany97 requested a review from nehaljwani as a code owner July 10, 2023 13:24
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@johnhany97
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/zipp-feedstock/actions/runs/5508647844.

@johnhany97
Copy link
Contributor Author

@nehaljwani would appreciate if you could review this PR at your earliest convenience

@dtreichler dtreichler mentioned this pull request Jul 10, 2023
4 tasks
@dtreichler
Copy link

The build current on conda-forge breaks python 3.7 environments. Is it possible to retract or otherwise patch the existing package?

@nehaljwani
Copy link
Member

One can open a PR at https://github.com/conda-forge/conda-forge-repodata-patches-feedstock for patching the repodata.

@h-vetinari
Copy link
Member

The build current on conda-forge breaks python 3.7 environments.

While we shouldn't break things gratuitously (and I'm fine with fixing this case), Python 3.7 is end-of-life and has been completely dropped by conda-forge since almost a year.

It should be considered completely unsupported, and I strongly recommend to upgrade your pythons ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants