Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 1.9.1 #10

Merged
merged 9 commits into from
Mar 11, 2025
Merged

update to 1.9.1 #10

merged 9 commits into from
Mar 11, 2025

Conversation

giovp
Copy link
Contributor

@giovp giovp commented Mar 11, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@giovp giovp requested a review from goanpeca as a code owner March 11, 2025 16:56
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python, or selector on line 24:
    • numpy >=1.22, <3.0 # [py>=39]

For recipe/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).
  • ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.
  • ℹ️ top-level output has some malformed specs:
  • In section host: `python >=3.9, <3.14
  • In section run: python >=3.9, <3.14, numpy >=1.22, <3.0, xarray >=2022.3, <2025.0 Requirement spec fields should always be space-separated to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build`.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13793769816. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • ❌ When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

For recipe/meta.yaml:

  • ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13794188402. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@giovp
Copy link
Contributor Author

giovp commented Mar 11, 2025

@h-vetinari @conda-forge/core I've fixed the CI here, updating to latest version, could you kindly merge this? thank you!
@jdblischak I've added you here as maintainer
@timtreis @melonora @LucaMarconato @giovp are maintainers of the scverse/spatialdata a package that relies on xarray-dataclasses

Copy link
Member

@jdblischak jdblischak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rerender the feedstock locally with conda smithy rerender --commit auto or comment in this PR with the phrase @conda-forge-admin, please rerender

Copy link
Member

@jdblischak jdblischak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @giovp!

@LucaMarconato
Copy link
Member

Thanks @giovp, happy to be added as a maintainer.

@h-vetinari
Copy link
Member

I've added you here as maintainer
@timtreis @melonora

Can you please confirm you want to be added as maintainers?

@melonora
Copy link

Hey! I can confirm

@timtreis
Copy link

I also confirm, thanks!

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants