Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-compile aarch64 #74

Merged
merged 7 commits into from
Jun 22, 2023
Merged

Cross-compile aarch64 #74

merged 7 commits into from
Jun 22, 2023

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Jun 13, 2023

The linux-aarch64 build failed on main. I'm moving this over to Azure as I generally trust the builds there much more than the ones on Azure.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy xhochy mentioned this pull request Jun 21, 2023
Closed
@xhochy xhochy mentioned this pull request Jun 22, 2023
Merged
5 tasks
@xhochy xhochy marked this pull request as ready for review June 22, 2023 04:55
@xhochy
Copy link
Member Author

xhochy commented Jun 22, 2023

@conda-forge/torchvision This is ready for review/merge.

h-vetinari
h-vetinari reviewed Jun 22, 2023
View reviewed changes
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Just a small change, then it LGTM

conda-forge.yml Outdated
Comment on lines 14 to 13
test_on_native_only: true
# Emulated tests exceed the 6h CI threshold
test: native
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer just skipping the test suite invocation on aarch, so we at least still have the import tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted.

h-vetinari
h-vetinari approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@h-vetinari h-vetinari merged commit 072ec57 into conda-forge:main Jun 22, 2023
@xhochy xhochy deleted the cross-compile-aarch64 branch June 23, 2023 05:40
@weiji14 weiji14 mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari h-vetinari approved these changes

@hmaarrfk hmaarrfk Awaiting requested review from hmaarrfk hmaarrfk is a code owner

@nehaljwani nehaljwani Awaiting requested review from nehaljwani nehaljwani is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xhochy @h-vetinari