WIP: Add nccl #8637
Closed
WIP: Add nccl #8637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a shim package to help conda-build interact with an **existing** nvcc install. Through this shim compiler package, users are able to ensure an appropriate cudatoolkit version is attached to the package and thus make sure that requirement is met at install time.
Needed so packages compiled with them can find them easily.
This reverts commit ee6f8a8.
This reverts commit fe0f5db.
Make sure that `libcudart` is a shared library dependency.
After talking with one of the NCCL developers, they confirmed that NCCL will only make breaking changes at major versions. So have added `run_exports` with a loose constraint here and reference to the upstream issue where this was discussed.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This was referenced Jul 11, 2019
|
What's the feeling on merging this in? Hardware support sounds super interesting |
|
I'm replacing this with PR ( #9694 ). Please take a look 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still very much WIP (because of the staged-recipes changes needed). Please do not review yet. Thanks. :)
This adds a package for NVIDIA's NCCL library. Requires the
nvccshim package for building. ( #8229 ) Leverages the recently added CUDA Docker images for building. ( conda-forge/docker-images#93 )Note: This includes some other stuff that I used to build this locally. Please ignore that for the moment. It can be cleaned out later.
cc @jjhelmus @seibert @dantegd @JohnZed @kkraus14
Checklist