Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package imutils #8572

Merged
merged 3 commits into from
Jun 19, 2019
Merged

Package imutils #8572

merged 3 commits into from
Jun 19, 2019

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Jun 18, 2019

Checklist
closes #8562

  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages
  • Build number is 0
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

Currently listed only myself as maintainer, but hoping one of the people tagged below will jump in as well.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/imutils) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

h-vetinari commented Jun 18, 2019

Optimistically tagging the package owner @jrosebr1 for possible (co-)maintainership, as well as some people who have already built a conda package for imutils: @pjamesjoyce @mlgill @gilbertfrancois @chriskan0305 @akode @thecampfire.

Would be happy to share the responsibility. :)

@h-vetinari
Copy link
Member Author

Seems the simple recipe based on conda skeleton pypi doesn't work everywhere (it did build locally for me). Will have to leave the debugging for later.

@h-vetinari h-vetinari changed the title add imutils recipe Package imutils Jun 18, 2019
@mlgill
Copy link

mlgill commented Jun 18, 2019

Please untag me from this discussion. Thank you.

@h-vetinari
Copy link
Member Author

@mlgill: Please untag me from this discussion. Thank you.

I can't do that for you, you'll have to click "unsubscribe" under "Notifications" in the top right-hand corner of the thread.

@jrosebr1
Copy link

Sorry @h-vetinari, but I cannot help in that regard. Between authoring the free PyImageSearch posts, helping others learn CV and DL, and of course, maintaining imutils itself, I just don't have the time for anything else.

@h-vetinari
Copy link
Member Author

Currently running into the issue that libGL is not found on linux, which seems to be intentional. I'm trying to glean some tricks from the meta.yaml of the feedstocks for opencv, qt and matplotlib. Let's see if this get's me anywhere.

@@ -0,0 +1 @@
mesa-libGL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to use mesa-libGL-devel if you need the headers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it looks like you don't use the headers, per se

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opencv doesn't use them either. Frankly, all I tried to do was to get a passing build. 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which it seems like you have done!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us know when this is ready for review

@h-vetinari
Copy link
Member Author

h-vetinari commented Jun 19, 2019

@scopatz: Let us know when this is ready for review

From my POV, this is ready! The PR template already mentioned that I cannot (yet) tag @conda-forge/help-python, so thanks for stopping by. :)

I would of course gladly accept more recipe maintainers, but as no-one (from the list I tagged) has spoken up in about 36h, I think I'll just bite the bullet.

@scopatz scopatz merged commit e648963 into conda-forge:master Jun 19, 2019
@scopatz
Copy link
Member

scopatz commented Jun 19, 2019

Thanks @h-vetinari!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Packaging imutils
5 participants