-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ECMWF cfgrib: open GRIB files with xarray #7837
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cfgrib:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/core this PR should be ready and safe to merge. Failures are the known issue #7715. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of suggestions.
extra: | ||
recipe-maintainers: | ||
- alexamici | ||
- StephanSiemen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StephanSiemen Are you happy to be listed as maintainer of this recipe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must say that I didn't explicitly ask him, but he is the head of the development section of ECMWF that commissioned to my company the development of cfgrib and we usually co-maintain all distribution channels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's standard for us to check that any additional maintainers are happy before merging new recipes (most of the time it's a formality, but occasionally people say no).
If you'd like it be merged faster you can remove this line and re-add him in the feedstock (which you can edit directly).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I am very happy to be added as a maintainer. Thanks @alexamici for the work!
Co-Authored-By: alexamici <[email protected]>
Co-Authored-By: alexamici <[email protected]>
Hi, this recipe adds the ability to work with the very popular GRIB file format in
xarray
on Linux, MacOS and Windows (with the next release).The need for a conda package is due to the
eccodes
dependency.