Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flake8-rst #6853

Merged
merged 4 commits into from
Oct 20, 2018
Merged

Added flake8-rst #6853

merged 4 commits into from
Oct 20, 2018

Conversation

FHaase
Copy link
Contributor

@FHaase FHaase commented Oct 18, 2018

Generated recipe via conda skeleton pypi flake8-rst

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/flake8-rst) and found it was in an excellent condition.

sha256: ec9c7b7a5475c0b3ce8aee4db951f33beffad68bdb79d99d45788d4aa083ce52

build:
number: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably be noarch: python:

https://conda-forge.org/docs/meta.html#building-noarch-packages

home: https://github.com/kataev/flake8-rst
license: MIT
license_family: MIT
license_file: LICENSE.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please raise an issue about the license_file missing from the source distribution upstream and put a link to the issue as a comment in the meta.yaml as a reminder for future releases.

Added `noarch: python`
Added link to PR 1

Signed-off-by: Fabian Haase <[email protected]>
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/flake8-rst) and found some lint.

Here's what I've got...

For recipes/flake8-rst:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [38]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/flake8-rst) and found some lint.

Here's what I've got...

For recipes/flake8-rst:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

Signed-off-by: Fabian Haase <[email protected]>
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/flake8-rst) and found it was in an excellent condition.

@synapticarbors synapticarbors merged commit 31b9494 into conda-forge:master Oct 20, 2018
@synapticarbors
Copy link
Member

@FHaase -- Thanks for your contribution to conda-forge. A feedstock for this recipe should be generated soon and you'll be receiving several automated messages about it. When the feedstock has been rendered, please take a look at the README in that repo for information about updating and maintaining the recipe. One of the key points is all updates should be done by forking that repo and following a standard pull request workflow. If you haven't looked at it already the docs are quite helpful:

https://conda-forge.org/docs/

If you run into any difficulties please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants