New package: cuda-histogram #27950

Saransh-cpp · 2024-10-21T15:14:08Z

Checklist

github-actions · 2024-10-21T15:16:02Z

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

recipes/cuda-histogram/meta.yaml:
- lints:
  - The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/scikit-hep. Please ask them to comment on this PR if they are.

conda-forge-admin · 2024-10-21T15:16:17Z

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory.

_{This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11443235746.}

conda-forge-admin · 2024-10-21T15:22:21Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-histogram/meta.yaml) and found it was in an excellent condition.

github-actions · 2024-10-21T15:33:12Z

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

conda-forge-admin · 2024-10-21T16:07:53Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-histogram/meta.yaml) and found some lint.

Here's what I've got...

For recipes/cuda-histogram/meta.yaml:

Non noarch packages should have python requirement without any version constraints.
Non noarch packages should have python requirement without any version constraints.

conda-forge-admin · 2024-10-24T13:22:17Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-histogram/meta.yaml) and found it was in an excellent condition.

recipes/cuda-histogram/meta.yaml

matthewfeickert · 2024-10-28T08:01:19Z

recipes/cuda-histogram/meta.yaml

+  number: 0
+  skip: True  # [win or osx or py<38]
+
+requirements:


It might be worth giving https://conda-forge.org/docs/maintainer/knowledge_base/#cuda-builds a read if you haven't already. I don't have any great advice here, but it might also be worth looking at how other tools that enable CUDA support have their conda-forge builds configured.

I don't know how to properly build CUDA enabled packages on conda-forge yet, but the failure on

+ pip check cuda-histogram 0.1.0 requires cupy-cuda12x, which is not installed.

is coming from the PyPI package dependency on cupy-cuda12x

dependencies = [ "cupy-cuda12x>=13.1.0", ... ]

Nothing provides this, but I don't know how to get around the dependency check.

@hmaarrfk 👋 Given your PR #26116 I'm curious if you have any advice or thoughts here.

Also cc @jakirkham given that you added cupy to conda-forge in the first place (huge thanks there! 🙇) in PR #9959.

Also forgot to mention, we have some more up-to-date docs

We have an issue open to refresh the webpage docs ( conda-forge/conda-forge.github.io#1927 ), which we are a bit behind on. Sorry about that 😞

Ah and one more suggestion here

Regarding the CI failure. This is coming from pip check. Basically pip is saying cupy-cuda12x is not installed, which is true as we just install it as cupy. In conda, packages depend on CUDA so have this information encoded as a dependency of the package. Currently wheels lack a way to do this; so, authors have resorted to encoding this information in the wheel name (like cupy-cuda11x and cupy-cuda12x)

To fix pip check, would recommend adding a patch in the recipe to change pyproject.toml to use the canonical name like so. That would fix the error

dependencies = [ - "cupy-cuda12x>=13.1.0", + "cupy>=13.1.0", "awkward>=2.6.3", "numpy>=1.22.0", "scipy>=1.1.0", "hist>=2", "boost-histogram", ]

jakirkham · 2024-10-29T01:30:26Z

recipes/cuda-histogram/meta.yaml

+    - python
+    - awkward >=2.6.3
+    - cupy >=13.1.0
+    - cuda-nvcc


Does the user need the CUDA compiler at runtime?

I assume strictly no, but I'll let @Saransh-cpp comment on that.

jakirkham · 2024-10-29T01:31:50Z

recipes/cuda-histogram/meta.yaml

+build:
+  script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
+  number: 0
+  skip: True  # [win or osx or py<38]


FWIW conda-forge is on Python 3.9+. So we can probably simplify this like so

Suggested change

skip: True # [win or osx or py<38]

skip: True # [win or osx]

conda-forge-admin · 2024-10-31T21:26:56Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-histogram/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipes/cuda-histogram/meta.yaml:

PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

Saransh-cpp · 2024-10-31T21:27:38Z

Sorry I am a bit inactive from work this week, but I will look into the comments soon. Thanks for all the help @matthewfeickert and @jakirkham, really appreciate it!

jakirkham · 2024-11-01T01:15:38Z

The next pip check failure appears to be about mplhep_data being out-of-date. There is a bot PR to update it ( conda-forge/mplhep_data-feedstock#4 ) however that PR has a minor issue that needs fixing for CI to be green. Once addressed this issue should also be fixed here

Co-authored-by: Matthew Feickert <[email protected]>

matthewfeickert · 2024-11-01T16:01:26Z

@Saransh-cpp Seems that maybe the new metadata hadn't had time to propagate out everywhere when this was ran, but given that I can see it now

$ pixi search mplhep_data
Using channels: conda-forge

mplhep_data pyhd8ed1ab_0
------------------------

Name                mplhep_data        
Version             0.0.4
Build               pyhd8ed1ab_0       
Size                5757500            
License             MIT AND OFL-1.1 AND LPPL-1.3c
Subdir              noarch             
File Name           mplhep_data-0.0.4-pyhd8ed1ab_0.conda
URL                 https://conda.anaconda.org/conda-forge/noarch/mplhep_data-0.0.4-pyhd8ed1ab_0.conda
MD5                 29e56ff931a12ce95d18614ad033a45c
SHA256              22648eeb812ce80bf2225054f9be80156bbdd567d780190383606a9ac2a421e2

Dependencies:
 - python >=3.7

maybe try again in an hour?

jakirkham · 2024-11-01T19:17:35Z

Thank you both! 🙏

Saransh caught a packaging bug with mplhep_data, which is causing its version not to be reported correctly in pip check. More details in this thread: conda-forge/mplhep_data-feedstock#4 (comment)

So we will want to sort that out to fix this issue

Saransh-cpp · 2024-11-01T19:33:04Z

Being fixed in conda-forge/mplhep_data-feedstock#5

matthewfeickert · 2024-11-01T21:59:40Z

Being fixed in conda-forge/mplhep_data-feedstock#5

That's merged now. 👍 So to give it time to propagate maybe try again in an hour (though you're in either the UK or India currently, @Saransh-cpp, so we can it till whenever you're awake and had some weekend rest to look at this again). :)

jakirkham · 2024-11-01T22:54:18Z

Thank you both! 🙏

Was able to pick up the fixed package locally and confirm the fix. So have restarted CI

matthewfeickert · 2024-11-02T07:41:46Z

@conda-forge/help-python, ready for review!

recipes/cuda-histogram/meta.yaml

Co-authored-by: jakirkham <[email protected]>

jakirkham · 2024-11-04T20:16:16Z

Thank you both! 🙏

jakirkham · 2024-11-04T23:40:13Z

The feedstock now lives here: https://github.com/conda-forge/cuda_histogram-feedstock

Also @Saransh-cpp to join conda-forge and have permissions on this feedstock, please follow these steps: conda-forge/cuda_histogram-feedstock@34a2ff4#commitcomment-148713846

Saransh-cpp · 2024-11-05T09:21:49Z

Thanks for all the help!

Saransh-cpp force-pushed the cuda-histogram branch from 0b9aa92 to 014bccb Compare October 21, 2024 15:14

Saransh-cpp force-pushed the cuda-histogram branch from e0be96d to bb96976 Compare October 24, 2024 13:20

matthewfeickert reviewed Oct 25, 2024

View reviewed changes

recipes/cuda-histogram/meta.yaml Outdated Show resolved Hide resolved

matthewfeickert reviewed Oct 28, 2024

View reviewed changes

jakirkham reviewed Oct 29, 2024

View reviewed changes

Saransh-cpp and others added 12 commits November 1, 2024 20:46

New package: cuda-histogram

d2940e8

plain cupy

b2005c3

update name

a196e87

rm scikit-hep for now

5bc9b68

update SHA

45f4720

try cuda version

6ba4987

remove noarch to restrict builds on windows and macos

f7eabae

remove python lower cap

c004155

try installing nvcc

20e2de2

Update recipes/cuda-histogram/meta.yaml

b7c1912

Co-authored-by: Matthew Feickert <[email protected]>

try patching

91198e4

no nvcc no py38

397bfc4

Saransh-cpp force-pushed the cuda-histogram branch from 021f3fd to 397bfc4 Compare November 1, 2024 15:16

github-actions bot added python review-requested labels Nov 2, 2024

jakirkham reviewed Nov 2, 2024

View reviewed changes

recipes/cuda-histogram/meta.yaml Show resolved Hide resolved

add a comment about cupy.patch

86a0e5a

Co-authored-by: jakirkham <[email protected]>

jakirkham merged commit d6a25ff into conda-forge:main Nov 4, 2024
9 checks passed

Saransh-cpp deleted the cuda-histogram branch November 5, 2024 09:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New package: cuda-histogram #27950

New package: cuda-histogram #27950

Saransh-cpp commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024

conda-forge-admin commented Oct 21, 2024 •

edited

Loading

conda-forge-admin commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

conda-forge-admin commented Oct 21, 2024 •

edited

Loading

conda-forge-admin commented Oct 24, 2024

matthewfeickert Oct 28, 2024

matthewfeickert Oct 28, 2024

matthewfeickert Oct 28, 2024

matthewfeickert Oct 28, 2024 •

edited

Loading

jakirkham Oct 31, 2024

jakirkham Oct 31, 2024 •

edited

Loading

jakirkham Oct 29, 2024

matthewfeickert Oct 31, 2024

jakirkham Oct 29, 2024

conda-forge-admin commented Oct 31, 2024

Saransh-cpp commented Oct 31, 2024

jakirkham commented Nov 1, 2024

matthewfeickert commented Nov 1, 2024

jakirkham commented Nov 1, 2024

Saransh-cpp commented Nov 1, 2024

matthewfeickert commented Nov 1, 2024

jakirkham commented Nov 1, 2024 •

edited

Loading

matthewfeickert commented Nov 2, 2024

jakirkham commented Nov 4, 2024

jakirkham commented Nov 4, 2024

Saransh-cpp commented Nov 5, 2024

New package: cuda-histogram #27950

New package: cuda-histogram #27950

Conversation

Saransh-cpp commented Oct 21, 2024 • edited Loading

github-actions bot commented Oct 21, 2024

conda-forge-admin commented Oct 21, 2024 • edited Loading

conda-forge-admin commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

conda-forge-admin commented Oct 21, 2024 • edited Loading

conda-forge-admin commented Oct 24, 2024

matthewfeickert Oct 28, 2024

Choose a reason for hiding this comment

matthewfeickert Oct 28, 2024

Choose a reason for hiding this comment

matthewfeickert Oct 28, 2024

Choose a reason for hiding this comment

matthewfeickert Oct 28, 2024 • edited Loading

Choose a reason for hiding this comment

jakirkham Oct 31, 2024

Choose a reason for hiding this comment

jakirkham Oct 31, 2024 • edited Loading

Choose a reason for hiding this comment

jakirkham Oct 29, 2024

Choose a reason for hiding this comment

matthewfeickert Oct 31, 2024

Choose a reason for hiding this comment

jakirkham Oct 29, 2024

Choose a reason for hiding this comment

conda-forge-admin commented Oct 31, 2024

Saransh-cpp commented Oct 31, 2024

jakirkham commented Nov 1, 2024

matthewfeickert commented Nov 1, 2024

jakirkham commented Nov 1, 2024

Saransh-cpp commented Nov 1, 2024

matthewfeickert commented Nov 1, 2024

jakirkham commented Nov 1, 2024 • edited Loading

matthewfeickert commented Nov 2, 2024

jakirkham commented Nov 4, 2024

jakirkham commented Nov 4, 2024

Saransh-cpp commented Nov 5, 2024

Saransh-cpp commented Oct 21, 2024 •

edited

Loading

conda-forge-admin commented Oct 21, 2024 •

edited

Loading

conda-forge-admin commented Oct 21, 2024 •

edited

Loading

matthewfeickert Oct 28, 2024 •

edited

Loading

jakirkham Oct 31, 2024 •

edited

Loading

jakirkham commented Nov 1, 2024 •

edited

Loading