-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ewah bool utils #21592
Adding ewah bool utils #21592
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/ewah-bool-utils:
Documentation on acceptable licenses can be found here. |
ping @matthewturk |
What's our best path forward here? We do vendor the underlying EWAH library (in accordance with their license) and I think it's fine if we don't for the purposes of conda, but we will need to pin the version as occasionally upgrading that library has required updating the C++ toolchain etc. |
Reading the fine letters it's actually okay to vendor it as long as we package the license too, which we already do. |
Alright I took a minute to double check and I confirm that we are indeed properly packaging the LICENSE file for the vendored (and modified, as allowed by said license) package. |
I hereby agree |
@conda-forge/staged-recipes I think this is ready for review |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).