-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyside2ads and qtadvanceddocking recipe #19017
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/qtadvanceddocking:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/qtadvanceddocking:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please restart ci |
@conda-forge-admin, please restart ci |
@conda-forge/help-python-c All requested changes have been made, could you please have a look again? |
- {{ cdt('libxxf86vm') }} # [linux] | ||
- {{ cdt('libxext') }} # [linux] | ||
- make # [not win] | ||
- libcxx # [linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang
is not our default compiler toolchain for linux. This is why the compiler directive is not installing libcxx for you.
Is there a reason that this project cannot compile with gcc
on linux? Your addition of clangdev is adding extra dependencies that are not being used by the build or at runtime.
- cmake | ||
- {{ compiler('c') }} | ||
- {{ compiler('cxx') }} | ||
- clangdev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stddef.h is not unique to clang it shouldn't require clangdev to be installed. Do you have a link to the spefic log output where this error occurred?
@conda-forge/help-python-c Could you please review again? This PR was not accepted because of clangdev dependency but I don't know how to compile without this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is broken. Please fix.
- cmake | ||
- {{ compiler('c') }} | ||
- {{ compiler('cxx') }} | ||
- clangdev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that recipe, the run_exports from clangdev are ignored.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).