Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nim (from source) #10046

Merged
merged 2 commits into from
Nov 8, 2019
Merged

Add Nim (from source) #10046

merged 2 commits into from
Nov 8, 2019

Conversation

pb-cdunn
Copy link

@pb-cdunn pb-cdunn commented Nov 2, 2019

Checklist

  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@pb-cdunn
Copy link
Author

pb-cdunn commented Nov 2, 2019

Alternative to #10045

@pb-cdunn pb-cdunn mentioned this pull request Nov 2, 2019
7 tasks
@pb-cdunn
Copy link
Author

pb-cdunn commented Nov 2, 2019

(New feedstock. How do I request a Merge?)

nim is a compiler which can generate C, C++, or Javascript from Nim source-code. It is itself a C-compiled executable. The Nim libs need to be available to users of nim. nimpretty and nimble are useful additional tools.

After this is merged, I will submit a follow-up PR for OSX and Win.

@pb-cdunn
Copy link
Author

pb-cdunn commented Nov 4, 2019

@conda-forge/staged-recipes ,

Seems to build ok. Can this be merged?

@pb-cdunn
Copy link
Author

pb-cdunn commented Nov 6, 2019

ping @conda-forge/staged-recipes

@pb-cdunn
Copy link
Author

pb-cdunn commented Nov 7, 2019

I am willing to be listed in the maintainers list.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/nim) and found it was in an excellent condition.

@pb-cdunn
Copy link
Author

pb-cdunn commented Nov 7, 2019

@conda-forge/staged-recipes We need this in Bioconda. Can we get this merged?

@pb-cdunn pb-cdunn changed the title Nim compile Add Nim Nov 7, 2019
@pb-cdunn pb-cdunn changed the title Add Nim Add Nim (from source) Nov 7, 2019
@pb-cdunn
Copy link
Author

pb-cdunn commented Nov 7, 2019

@marcelotrevisani @mariusvniekerk @xhochy @scopatz ,

This package is much simpler than it sounds. Nim simply generates C code (or C++), and then calls the C compiler to build. It's not that different than make or meson.

Right now, to use Nim in Bioconda I have to download (and maybe build) the Nim compiler inside the recipe, which takes a few minutes. This recipe will reduce the burden on CircleCI.

(I would close #10045, but if you'd rather simply install the nightly prebuilt, that would work fine for me.)

@xhochy xhochy merged commit 3e65f7f into conda-forge:master Nov 8, 2019
@pb-cdunn
Copy link
Author

pb-cdunn commented Nov 8, 2019

Shall I submit updates as PRs against the new nim-feedstock?

@xhochy
Copy link
Member

xhochy commented Nov 8, 2019

Shall I submit updates as PRs against the new nim-feedstock?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants