spyder v5.4.5 #147
Merged
spyder v5.4.5 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nda-forge-pinning 2023.08.29.11.33.45
regro-cf-autotick-bot
requested review from
andfoy,
ccordoba12,
dalthviz and
steff456
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
1 task
…oment Co-authored-by: Bradley Kreider <[email protected]>
|
@ccordoba12 is the change in the new commit the expected one? |
|
Yep, that's ok. Thanks @dalthviz! |
bkreider
reviewed
Sep 5, 2023
| @@ -5,6 +5,7 @@ set MENU_DIR=%PREFIX%\Menu | |||
| IF NOT EXIST (%MENU_DIR%) mkdir %MENU_DIR% | |||
|
|
|||
| copy %SRC_DIR%\img_src\spyder.ico %MENU_DIR%\ | |||
| copy %SRC_DIR%\img_src\spyder_reset.ico %MENU_DIR%\ | |||
There was a problem hiding this comment.
I don't think this line is needed as you aren't using the reset icon, but the spyder.ico file below. Or maybe in the future you will update the spyder_reset.ico and this makes that PR easier?
There was a problem hiding this comment.
Or maybe in the future you will update the spyder_reset.ico and this makes that PR easier?
Exactly! That's the idea 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6018424874, please use this URL for debugging.