Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pid_t definition in windows #767

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Jan 12, 2025

It's not used at all and might conflict with winpthreads-devel definition

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12733033264. Examine the logs at this URL for more detail.

@isuruf isuruf merged commit b02fcbb into conda-forge:main Jan 13, 2025
25 checks passed
@isuruf
Copy link
Member Author

isuruf commented Jan 13, 2025

Thanks

@tobiasdiez
Copy link

Awesome, thanks! Would it be easy to backport this fix to Python 3.11 and 3.12?

@isuruf
Copy link
Member Author

isuruf commented Jan 27, 2025

You can send a PR to the 3.11 and 3.12 branches. See recipe/patches/README.md on how to referesh patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants