-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pandas v2.0.0 #159
pandas v2.0.0 #159
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Added |
from pandas-dev/pandas#51247 (comment) , it looks like you've done exactly that - @lithomas1 do you know what the issue might be? the logs show
|
should |
Co-authored-by: Filipe <[email protected]>
I presume you mean 3.9? Pandas isn't compatible with just For context, here's the issue where it was suggested to add tzdata as a dependency pandas-dev/pandas#49048 |
Thank you, found the discussion about it later, hence the deleted comment. |
run: | ||
- python | ||
- {{ pin_compatible('numpy') }} | ||
- python-dateutil >=2.8.1 | ||
- pytz >=2020.1 | ||
- python-tzdata >=2022a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, tzdata is included in modern Python but pip is designed to find it only if installed by the python alternative like this. We could probably drop the pip check
test too. But "overi-nstalling" tzdata is not a big deal and probably better than dropping the pip-check.
Seems like we have a failure in a build:
I guess something went wrong with conda. @ocefpaf have you seen this before? Do you think we should just rerun that build? |
It may requite a restart. Let's wait for the rest of the CIs to finish before we restart it. |
BTW, we should wait for conda-forge/status#143 to be resolved before merging this one. |
The ppc ones had some real failures. Looks like precision stuff and maybe be same to skip, not sure. |
Thanks for the help and for the info. We found the error with ppc on the release candidates, we're happy to release without ppc. Hopefully we have a fix for pandas 2.0.1. Let's see if we're more lucky with the second attempt of the other error. It starts to be late in Dubai where I am, but for anyone else in a better time zone, feel free to merge this if only ppc is failing. Otherwise I'll take care of it tomorrow morning my time. |
Feel free to merge if conda-forge/status#143 is also addressed I mean. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)