Overwrite the libcuda.so symlink if present
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the `libcuda.so` symlink could have been added during a previous activation (and deactivation may not have occurred yet, like logging out), the symlink may already be there when we try to create it. In this case, just go ahead and forcibly overwrite the symlink with a new one.
Now that we have changed how the activation script works, bump the build number to create a new package with this change.
jakirkham
requested review from
dillon-cullinan,
isuruf,
kkraus14,
mike-wendt and
raydouglass
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@jakirkham so if I'm understanding this correctly this is to protect against say: Where both environment_1 and environment_2 have the nvcc package? |
|
Almost. It protects against this. Possibly with other steps in-between. |
kkraus14
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
libcuda.sosymlink could have been added during a previous activation (and deactivation may not have occurred yet, like logging out), the symlink may already be there when we try to create it. In this case, just go ahead and forcibly overwrite the symlink with a new one.Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Note: Re-rendering is currently broken for this feedstock. ( #18 ) So not handling that in this PR.