Rebuild for python 3.13 #152
Conversation
…nda-forge-pinning 2025.01.28.22.50.30
regro-cf-autotick-bot
requested review from
henryiii,
jakirkham,
marcelotrevisani,
mbargull,
souravsingh and
step21
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
The ARM failures might be due to a binfmt bug: pypa/cibuildwheel#2257 |
|
Thanks Henry! 🙏 Looks like a couple Linux Though interestingly only Python 3.10 and 3.11. Not the Python 3.13 being added |
Which ones? All failed checks are either |
|
I think it's "tests didn't finish before timeout" that I'm seeing after rerunning. Though some tests are segfaulting. I thought we are skipping tests one these two platforms, actually. |
|
This is getting the wrong architecture. It's not setting |
| @@ -17,7 +17,7 @@ cxx_compiler: | |||
| cxx_compiler_version: | |||
| - '13' | |||
| docker_image: | |||
| - quay.io/condaforge/linux-anvil-ppc64le:alma9 | |||
There was a problem hiding this comment.
Why are these images changing?
There was a problem hiding this comment.
The images change to match the build architecture when using cross-compiling
| build_platform: | ||
| linux_aarch64: linux_64 |
There was a problem hiding this comment.
Is this trying to cross-compile instead of emulate now?
There was a problem hiding this comment.
I know how to build with emulation now, but let's see if we can handle cross-compilation first.
Not sure why we run the tests in the build step.
There was a problem hiding this comment.
Yes this is how cross-compilation is configured
Signed-off-by: Henry Schreiner <[email protected]>
|
@jakirkham okay with this? I think longer-term we should move the tests to a test step, and maybe try running a few when cross-compiling; I'd assume the test step runs in emulation. |
|
The imports work and we don't have any tests working in emulation anyway, so let's go with this, and improve later if needed. |
Meaning moving to cross-compilation? Yes think that is ok Emulation can be kind of slow Ideally we would add the tests as emulated. Though this can be a bit tricky to setup right |
Doesn't this happen by default when cross-compiling? |
|
It should if the tests are in the test step. Ours are in the build step for some reason. |
This PR has been triggered in an effort to update python313.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/13039528494 - please use this URL for debugging.