Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild with new build tic program in ncurses to fix cross compilation #98

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Jan 29, 2025

Note that we have a

requirements:
  build:
    - ncurses   # [build_platform != target_platform]

to use tic, but for linux-aarch64 and linux-ppc64le, we used tic that was built with mixed cases enabled. rebuilding should fix this.

Fixes the error in conda-forge/python-feedstock#770 (comment)

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13032682724. Examine the logs at this URL for more detail.

@isuruf
Copy link
Member Author

isuruf commented Jan 29, 2025

@conda-forge/ncurses, this is ready

1 similar comment
@isuruf
Copy link
Member Author

isuruf commented Jan 29, 2025

@conda-forge/ncurses, this is ready

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a bit to grasp what's going on here - tic is not a package but bin/tic is shipped by ncurses, and for cross-compiling ncurses, we already need ncurses here:

- ncurses # [build_platform != target_platform]

Therefore, the builds from #97 did only the first step in that cycle, and this does the second.

@h-vetinari h-vetinari merged commit ff4c9e3 into conda-forge:main Jan 30, 2025
8 checks passed
@isuruf isuruf deleted the tic branch January 30, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants