Build installer on Docker

[hadim]

First try.

[hadim]

LGTM for me. There is one remaining point that we can address later because it needs an upstream fix: conda-forge/docker-images#122

Once merged into master, someone should tag a first release (maybe < than 1.0 to begin with).

[isuruf]

We should wait on tagging a release and publishing it.

[hmaarrfk]

Agreed, I should have just asked hadim to fork off my working branch. Don't know why I didn't think of that.

[hmaarrfk]

I think we should comment out the power and x86 platforms.

[hadim]

Currently, there is an issue with conda complaining about a missing tqdm on aarch64 when executing conda update/install. I am trying to reproduce the bug on Travis. It does not happen on the amd64 installer.

[hadim]

For versioning, I think we should do it ourselves in the git tag of this repo:

git tag 4.7.11-0

Then the build script picks it up with $(git describe).

[hadim]

Or so we're all good with channels?

[isuruf]

Yes, the channels are good. Does the installer use the conda version given $(git describe)?

[hadim]

yes: https://github.com/conda-forge/miniforge/pull/2/files#diff-d99b26f864526f6f8f79861d49deb922R21

[hadim]

oh no sorry, I misunderstood your question.

[hadim]

Something like that at the beginning of the build script:

CONDA_VERSION=$(git tag --points-at HEAD)
# example: CONDA_VERSION="4.7.11-0"
if [ -z "$CONDA_VERSION" ]
then
  echo "***** No Conda version detected in git tag.*****"
else
  CONDA_VERSION=$(echo $CONDA_VERSION | cut -d "-" -f 1)
  echo "***** Conda version detected in git tag: $CONDA_VERSION *****"
  echo "Install appropriate conda version."
  conda install -y "conda=$CONDA_VERSION"
fi

[hadim]

We should test it on master once merged (we can always remove tags if something goes wrong)

[hadim]

and then we read it in build.sh? That would be simpler actually.

[isuruf]

I meant, reading from git version and then adding that version constraint to construct.yaml.

[hadim]

What do you think about setting the version in construct.yaml manually and then in the build script:

MINIFORGE_VERSION=$(cat Miniforge/construct.yaml | grep version | cut -d ":" -f 2)
CONDA_VERSION=$(echo $MINIFORGE_VERSION | cut -d "-" -f 1)

echo "***** Install conda version: $CONDA_VERSION *****"
conda install -y "conda=$CONDA_VERSION"

[hadim]

Once in master we tag whatever we want (MINIFORGE_VERSION would be better ofc) to get the build uploaded.

[hadim]

If we get the version from tags, it's weird because it's harder to update conda version from a PR.

[isuruf]

What I'm saying is you need,

name: Miniforge
version: 4.7.11-0

channels:
  - https://conda.anaconda.org/conda-forge
  # This will continue to be a dependency until the compilers are
  # moved to conda-forge.
  - https://conda.anaconda.org/c4aarch64   [linux-aarch64]
write_condarc: True
license_file: ../LICENSE
specs:
  - python >=3,<3.8
  - conda 4.7.11
  - pip

Note the version on conda.

[hadim]

Of course, it's even simpler that way :-)

[hmaarrfk]

Looks great. Two small questions

[hadim]

This PR starts to be very long. After you've reviewed my last commits, I would like to merge this into master. As long as there is not tag nothing will be released anyway. What do you guys think?

[hmaarrfk]

I'm good with that

[hadim]

@isuruf are you good if we merge this?