-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libignition-rendering4 v6_6.0.0 #19
libignition-rendering4 v6_6.0.0 #19
Conversation
…a-forge-pinning 2021.09.30.20.35.40
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Blocked by conda-forge/libignition-math4-feedstock#18 . |
There is some interesting build failures when using ogre1.10 only on Linux and macOS (not on Windows):
|
I think there is some regression related to gazebosim/gz-rendering#376 . I reverted it that part for now in our recipe. |
The failures could also be related to ignition-cmake 2.9.0 and some related changes:
In particular in that changes there is a lot of code that is conditional on:
All aspects related to the failures of this PR. |
Reverting to finding ogre like:
Results in compilation working fine, but tests on macOS failing tests failing like:
Interestingly, the same test pass fine (at least for ogre 1.12, that was the one that was working fine even when 1.10 had compilation problems) before the revert of the |
As a compromise before the unpatched version (in which tests were passing on macOS with ogre 1.12) I tried to search passing as |
So, small recap after all the experiments in CI. Compilation or tests are failing either on
|
Even after the fix backported from gazebosim/gz-rendering#454, the macOS tests are segfaulting. However, also the tests in Linux seems to be passing but in a strange way. It seems that they are try to test only the disabled engines (ogre2 and optix) and they silently fail, without actually testing ogre:
This would explain why the test suite was passing fine on all old releases. |
It seems that this is expected as the render engines to tests are hardcoded: https://github.com/ignitionrobotics/ign-rendering/blob/ign-rendering6/test/test_config.h.in#L14 . To specify other render engines, it is possible to use the |
Great, progress. Now also Windows and Linux fail. : ) Windows fail with errors like:
Linux fails (but silently passes) with errors like:
This is probably just some yum packages related to libgl missing in the test machine. |
See https://conda-forge.org/docs/maintainer/knowledge_base.html#libgl . |
@conda-forge-admin please rerender |
…a-forge-pinning 2021.10.06.22.07.41
So, we finally reached a point in which all the tests are failing. However, especially the Linux tests are clearly failing because the display can't be opened, and this is kind of expected on a CI environment in which First of all, I tested on macOS the |
Apparently, the |
@conda-forge-admin please rerender |
…a-forge-pinning 2021.10.06.22.07.41
It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:
Checklist before merging this PR:
license_file
is packagedNote that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
NEW: If you want these PRs to be merged automatically, make an issue with
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable.Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1293598365, please use this URL for debugging
Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: false
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.
Packages found by inspection but not in the meta.yaml: