Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure a value for noarch_platform when rerendering #99

Merged

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #98.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

Fixes #98

@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub actions workflow below for more details. You can also ping conda-forge/core for further assistance or you can try [rerendering locally](https://conda-forge.org/docs/maintainer/updating_pkgs.html#rerendering-with-conda-smithy-locally.

The following suggestions might help debug any issues:

  • Is the recipe/{meta.yaml,recipe.yaml} file valid?
  • If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
  • Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11149177857.

@jakirkham
Copy link
Member

jakirkham commented Oct 2, 2024

The error message above is a bit confusing. The actual error is this

conda_build.exceptions.CondaBuildUserError: Failed to render jinja template in /tmp/tmpc1uu4vku/jupyter_core-feedstock/recipe/meta.yaml:
'noarch_platform' is undefined

However that part of the workflow is shown as passing

Is there some way to bubble up the error/traceback for the user?

cc @beckermr

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@beckermr
Copy link
Member

beckermr commented Oct 2, 2024

Yes we likely can but it will take some work.

@beckermr
Copy link
Member

beckermr commented Oct 2, 2024

Also there is a formatting bug I need to fix.

@jakirkham
Copy link
Member

jakirkham commented Oct 2, 2024

Thanks Matt! 🙏

For the 1st one, filed issue: conda-forge/conda-forge-webservices#721

For the 2nd one, filed PR: conda-forge/conda-forge-webservices#723

@Carreau
Copy link
Contributor

Carreau commented Oct 3, 2024

@conda-forge-admin , please re-render

@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11158669815.

@bollwyvl
Copy link
Contributor

bollwyvl commented Oct 3, 2024

Seems like a fine change, in line with other things we've had to do elsewhere. Will set to auto-merge... any other context here?

@bollwyvl bollwyvl added the automerge Merge the PR when CI passes label Oct 3, 2024
@bollwyvl
Copy link
Contributor

bollwyvl commented Oct 3, 2024

@conda-forge-admin please rerender

@bollwyvl bollwyvl changed the title MNT: rerender Ensure a value for noarch_platform when rerendering Oct 3, 2024
@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11162152818.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@github-actions github-actions bot merged commit 4acbac1 into conda-forge:main Oct 3, 2024
5 checks passed
@bollwyvl
Copy link
Contributor

bollwyvl commented Oct 3, 2024

Should the 10 other meta.yaml also do this?

@jakirkham
Copy link
Member

That or we should file a conda-build issue

A different option would be to try rattler-build and see if that works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin , please re-render
5 participants